Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no more infinite error loop if cart creation fails #2574

Merged
merged 10 commits into from
Jul 29, 2020
Merged

fix: no more infinite error loop if cart creation fails #2574

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c76863
Gracefully exit the getCartDetails action when there is an error crea…
sirugh Jul 23, 2020
df0100f
Remove leading comments
sirugh Jul 23, 2020
b06e245
Gracefully handle other instances of create cart failure in actions
sirugh Jul 23, 2020
dd1ae7d
Simplify logging into single action catch
sirugh Jul 24, 2020
10fbeca
Add cart creation error to cart state for future handling
sirugh Jul 24, 2020
3cf83cd
In PDP, handle cases where cart id is null on add
sirugh Jul 24, 2020
fde3444
Remove error if create cart is successfull
sirugh Jul 27, 2020
ac4de23
Merge branch 'develop' into rugh/pwa-732-infinite-gql-errors
sirugh Jul 28, 2020
f362153
Fix tests
sirugh Jul 28, 2020
de6bd81
Merge branch 'develop' into rugh/pwa-732-infinite-gql-errors
dpatil-magento Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove error if create cart is successfull 
Signed-off-by: sirugh <[email protected]>
  • Loading branch information
@sirugh
sirugh committed Jul 27, 2020
commit fde344407fe73681c0e8a712978a9ac11cb4efc6
3 changes: 2 additions & 1 deletion packages/peregrine/lib/store/reducers/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ const reducerMap = {

return {
...state,
cartId: String(payload)
cartId: String(payload),
getCartError: null
};
},
[actions.getDetails.request]: state => {
Expand Down