fix: move cart creation out of trigger

[sirugh]

Description

For some reason the cart trigger owns cart creation. When the component mounts it invokes a "getCartDetails" action, which in turn checks for existence of a cart id and if it doesn't find one, calls the "createCart" action, which does another check for cart id and if it also doesn't find one, invokes a mutation to create a cart.

This could be simpler. We can move cart creation to the cart context provider.

Related Issue

Closes PWA-776.

Acceptance

Verification Stakeholders

Specification

Verification Steps

1. Clear cache and refresh. A cart id should be fetched (via createCart) from the context provider instead of the trigger.
2. Log in. In the dev tools, modify your signin_token to invalidate it (remove a character).
3. Refresh the page. You should see errors logged in console from graphql about unauthorized access, but then you should see those queries be remade with a valid cart id and the user token should be removed.

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.

• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Messages
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Associated JIRA tickets: PWA-776.

Generated by 🚫 dangerJS against 141e644

[devops-pwa-codebuild]

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2572.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92, WPT Cache Expected 90 Actual 83.333333333333
https://pr-2572.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.29, LH Best Practices Expected 1 Actual 0.92
https://pr-2572.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.41, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92, WPT Cache Expected 65 Actual 50

[jimbo]

Good explanation.

[revanth0212]

I can see that the error message is being logged, kudos to that.

Followup question, should we change the errorLink function in venia-concept/src/index.js to better represent locations object instead of [object Object].

I don't want to scope creep here but if you are willing to, that would be great.

[jimbo]

Yes, I meant to bring this up when I mentioned that this was the first query in peregrine. 💯