-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add note about Node 12 deprecation warnings #2566
[Doc] Add note about Node 12 deprecation warnings #2566
Conversation
|
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2566.pwa-venia.com : LH Performance Expected 0.85 Actual 0.52, LH Best Practices Expected 1 Actual 0.92, WPT Cache Expected 90 Actual 83.333333333333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but I don't see any deprecation warnings on develop
; any chance we solved this, or I'm missing a step to repro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should clarify that the warning will say the following:
(node:89176) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
@@ -17,6 +17,10 @@ During the course of the tutorials, you will create a new storefront application | |||
- Node >= 10.14.1 | |||
- Yarn (recommended) or NPM | |||
|
|||
{: .bs-callout .bs-callout-info} | |||
If you are using Node 12, you may see a deprecation warning in your logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification steps pass, QA Approved. |
Description
Adds a note about a deprecation warning that shows up in the log when using Node12. This is caused by a dependency and is noted where we specify Node requirements.
Related Issue
Closes PWA-698
Acceptance
Any developer
Verification Stakeholders
Any developer
Specification
Verification Steps
Run HTML preview server
Verify note appears on the following pages:
/tutorials/pwa-studio-fundamentals/
/tutorials/pwa-studio-fundamentals/project-setup/
/venia-pwa-concept/features/modular-components/
/venia-pwa-concept/setup/
Screenshots / Screen Captures (if appropriate)
Checklist