-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-623]: Update Venia's inputs #2510
[PWA-623]: Update Venia's inputs #2510
Conversation
- copy tokens to `venia-ui` - move index.css to `venia-ui` - update global vars and move to tokens - update custom property name references
- update serif font fallback value - update @font-face weights in templates - add serif @font-face in templates
# Conflicts: # packages/venia-concept/template.html # packages/venia-ui/lib/components/Footer/footer.css # packages/venia-ui/templates/default-font-include.mst
- use absolute paths to import `venia-ui` in `venia-concept`
- update existing CSS custom properties to use the new values
- Initial styling for new button styles
- use functional color notation
- Fix various buttons throughout the app
- Fix various buttons throughout the app
- Create <LinkButton /> component
- Update hover state to new colors - Fix various buttons throughout site - Fix estimate shipping info inconsistencies
# Conflicts: # packages/venia-ui/lib/tokens.css
- Update unit test snapshots
- Update filter and sort buttons - Make icons the same color in account area - Fix shipping estimate button
- Prettier & update snapshots
- Update all colors to match new designs
- Fix color commas
- Revert style guide changes
- Update teal colour to use blue
- update style for text inputs - update icon size within text inputs
# Conflicts: # packages/venia-ui/lib/components/Button/button.css # packages/venia-ui/lib/components/Checkout/flow.css # packages/venia-ui/lib/components/MiniCart/emptyMiniCartBody.css # packages/venia-ui/lib/components/ProductSort/productSort.css # packages/venia-ui/lib/components/SignIn/signIn.css # packages/venia-ui/lib/tokens.css
- Update search page filter button
- update style for search input with autocomplete dropdown
- Update usage of rgba with var usage - Fix flex- usage
- use class modifiers
- fix stepper style cascading - update error message style
- remove redundant properties
- remove unused props
- remove unused class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny console.log needs removed, but this is approved 👍
Co-authored-by: Tommy Wiebell <[email protected]>
@jimbo we see minor issue in Android device where Radios in Qty drop down, County/State in shipping form dropdown does not look same as rest of site. But its very specific to how android handles it, iOS don't have issue as there is no Radios on these fields. Does this needs to be handled? cc @anthoula |
That's working as intended. No fix necessary. 👍 |
QA Approved. |
Description
Adjust input styles to match the new design
Related Issue
https://jira.corp.magento.com/browse/PWA-623
Acceptance
Verification Stakeholders
@soumya-ashok
@jimbo
@dpatil-magento
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist