Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docker file to get syntax highlighting #2374

Merged
merged 4 commits into from
May 5, 2020
Merged

Rename docker file to get syntax highlighting #2374

merged 4 commits into from
May 5, 2020

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented May 1, 2020

Description

Is your feature request related to a problem? Please describe.*
Using Dockerfile.dev or Dockerfile.prod you'll lose syntax highlighting as Dockerfile should be the extention.

Describe the solution you'd like
Changing to dev.dockerfile and prod.dockerfile etc. will be much more convenient.

Related Issue

Closes #2198

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. CI builds should pass.
  2. bash docker/run-docker should be successful.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@dpatil-magento dpatil-magento added the CI_APPROVED This PR should be included in the CI process. label May 1, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 1, 2020

Fails
🚫 Issue 2198 is closed. Please make sure the linked issue is correct and open.
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against abb057a

@dpatil-magento
Copy link
Contributor

Verification steps pass, waiting for related PR in CI repo to get approved.

@dpatil-magento dpatil-magento merged commit 46ca284 into magento:develop May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI_APPROVED This PR should be included in the CI process. Partner: TechDivision partners-contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: change Dockerfile.env to env.Dockerfile
5 participants