Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Checkout Page Price Adjustments #2366

Merged
merged 22 commits into from
May 5, 2020
Merged

[feature] Checkout Page Price Adjustments #2366

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8a575d3
Initial
sirugh Apr 21, 2020
8419919
Matches colump gap for coupon and gift card between input and button
sirugh Apr 29, 2020
88d50a2
fix column css for mobile view
sirugh Apr 29, 2020
8f51d78
Update styling to match new mock for gift card.
sirugh Apr 29, 2020
9499019
Updates tests
sirugh Apr 29, 2020
13e9cee
Switch back to column - oops
sirugh Apr 29, 2020
5897f49
Cleanup tests and todos
sirugh Apr 29, 2020
0c07a18
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
sirugh Apr 30, 2020
7eaa0fe
Add missing import
sirugh Apr 30, 2020
e1f931d
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
sirugh Apr 30, 2020
8b75db4
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
sirugh May 1, 2020
ffcc62e
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
sirugh May 4, 2020
a24a101
Uses a more explicit error message when invalid coupon applied
sirugh May 4, 2020
d8bd79a
Removes hard coded color for coupon remove button
sirugh May 4, 2020
5e6b200
Fix tests and snaps
sirugh May 4, 2020
7ae8b14
reset form after apply
sirugh May 4, 2020
7717684
Add helpful comment
sirugh May 4, 2020
ec6ce21
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
sirugh May 4, 2020
b87b2e7
Feedback
sirugh May 5, 2020
2af70d5
fix test
sirugh May 5, 2020
c6c604a
Fix lint
sirugh May 5, 2020
23a60b1
Merge branch 'develop' into rugh/pwa-248-checkout-price-adjustments
dpatil-magento May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Matches colump gap for coupon and gift card between input and button 
Signed-off-by: sirugh <[email protected]>
  • Loading branch information
@sirugh
sirugh committed Apr 29, 2020
commit 8419919ddbb5a5b588e7d03de50d2d05df49cb45
2 changes: 1 addition & 1 deletion packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/couponCode.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
.entryForm {
display: grid;
grid-template-columns: 1fr 1fr;
grid-column-gap: 2rem;
grid-column-gap: 1rem;
}

.applyButton {
Expand Down