Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] revise the update footer tutorial #2299

Merged
merged 8 commits into from
Mar 31, 2020

Conversation

jcalcaben
Copy link
Contributor

Description

Revise and publish the Update Footer tutorial contributed by @rossmc

Related Issue

Closes PWA-302

Acceptance

Any developer

Verification Stakeholders

Any developer

Specification

Verification Steps

  1. navigate to the pwa-devdocs directory: cd pwa-devdocs
  2. Run linter on file: yarn lint src/tutorials/pwa-studio-fundamentals/modify-site-footer
  3. Verify no linting issues
  4. Run preview server: yarn develop
  5. Navigate to HTML preview site and go to the Tutorials section
  6. Verify item appears on left navigation and links to the correct page
  7. Verify page renders and content is accurate

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Mar 31, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 31, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-302.

Generated by 🚫 dangerJS against dafb5cb

Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from the technical side

@dpatil-magento dpatil-magento merged commit be66a41 into develop Mar 31, 2020
@dpatil-magento dpatil-magento deleted the jimothy/pwa-302_revise-update-footer-tutorial branch March 31, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation documentation This pertains to documentation. pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants