Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository url in package.json files #210

Merged
merged 5 commits into from
Aug 8, 2018
Merged

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Aug 4, 2018

After moving to monorepo urls to repositories and other stuff remains old, which is kinda confusing while you are trying to find the package source on npmjs.org

@magento-cicd2
Copy link

magento-cicd2 commented Aug 4, 2018

CLA assistant check
All committers have signed the CLA.

@zetlen
Copy link
Contributor

zetlen commented Aug 8, 2018

Thank you so much, @Igloczek! This addresses #195 to some degree and we'll definitely merge it. I don't think it closes #195, because we'd like to have checks in our Dangerfile to make sure these stay correct.

@zetlen
Copy link
Contributor

zetlen commented Aug 8, 2018

@Igloczek The build is failing because DangerCI doesn't currently work in CircleCI on forked pull requests. We're working on a way to fix it. In the meantime, this is a definite merge.

@zetlen zetlen merged commit e0b8232 into magento:master Aug 8, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 484

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-3.04%) to 53.786%

Files with Coverage Reduction New Missed Lines %
packages/pwa-buildpack/src/WebpackTools/MagentoResolver.js 5 0.0%
packages/pwa-buildpack/src/WebpackTools/middlewares/StaticRootRoute.js 7 0.0%
packages/venia-concept/src/util/makeMediaPath.js 8 0.0%
packages/pwa-buildpack/src/util/options-validator.js 17 0.0%
packages/pwa-buildpack/src/WebpackTools/middlewares/OriginSubstitution.js 18 0.0%
Totals Coverage Status
Change from base Build 480: -3.04%
Covered Lines: 835
Relevant Lines: 1616

💛 - Coveralls

@Igloczek Igloczek deleted the patch-1 branch September 4, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants