Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB] PWA - Alignment Inheritance for Button Group Doesn't Work & Slide Overlay/Links Don't Work #2085

Merged
merged 1 commit into from
Jan 8, 2020
Merged

[PB] PWA - Alignment Inheritance for Button Group Doesn't Work & Slide Overlay/Links Don't Work #2085

merged 1 commit into from
Jan 8, 2020

Conversation

eug123
Copy link
Contributor

@eug123 eug123 commented Jan 7, 2020

Description

PWA - Alignment Inheritance for Button Group Doesn't Work & Slide Overlay/Links Don't Work

Related Issue

https://jira.corp.magento.com/browse/PB-345

Verification Steps

See https://jira.corp.magento.com/browse/PB-345

@eug123
PB-345: PWA - Alignment Inheritance for Button Group Doesn't Work & S…
bf992d1 
…lide Overlay/Links Don't Work (For Exact Data in Ticket)
@PWAStudioBot
Copy link
Contributor

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-345.

Generated by 🚫 dangerJS against bf992d1

@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jan 8, 2020
@davemacaulay davemacaulay merged commit f8a11d6 into magento:release/5.0 Jan 8, 2020
@dpatil-magento dpatil-magento mentioned this pull request Jan 10, 2020
Merged
@davemacaulay davemacaulay deleted the PB-345 branch June 1, 2020 14:06
@davemacaulay davemacaulay restored the PB-345 branch June 1, 2020 14:06
@davemacaulay davemacaulay deleted the PB-345 branch June 1, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemacaulay davemacaulay davemacaulay approved these changes

Assignees
No one assigned
Labels
pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eug123 @PWAStudioBot @davemacaulay