Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): report results to CircleCI via JUnit #201

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

zetlen
Copy link
Contributor

@zetlen zetlen commented Aug 1, 2018

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[x] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will adjust CI and DangerCI setup to

  • always run tests, even on non-PR branches that don't run Danger
  • reuse test results in Danger analysis
  • output and store test results in CircleCI for better analysis purposes

@coveralls
Copy link

coveralls commented Aug 2, 2018

Pull Request Test Coverage Report for Build 548

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 462 unchanged lines in 35 files lost coverage.
  • Overall coverage decreased (-26.4%) to 30.46%

Files with Coverage Reduction New Missed Lines %
packages/venia-concept/src/shared/images.js 1 0.0%
packages/venia-concept/src/util/timeout.js 1 0.0%
packages/peregrine/src/store/middleware/log.js 1 0.0%
packages/peregrine/src/store/middleware/index.js 2 0.0%
packages/peregrine/src/util/unaryMemoize.js 3 0.0%
packages/venia-concept/src/util/initObserver.js 4 0.0%
packages/venia-concept/src/util/fixedObserver.js 4 0.0%
packages/venia-concept/src/components/Button/button.js 4 0.0%
packages/venia-concept/src/classify.js 4 0.0%
packages/peregrine/src/store/index.js 5 0.0%
Totals Coverage Status
Change from base Build 525: -26.4%
Covered Lines: 519
Relevant Lines: 1709

💛 - Coveralls

@zetlen zetlen force-pushed the zetlen/ci-test-reporting branch 6 times, most recently from 7df9402 to bb566b6 Compare August 2, 2018 15:34
And configure DangerCI to consume them

fix(ci): use github API to patch CI env
@zetlen
Copy link
Contributor Author

zetlen commented Aug 10, 2018

I'm 😱 unilaterally 😱 merging this, because our broken tests are making it hard to evaluate other PRs for stability, and it's blocking everyone.

@zetlen zetlen merged commit d0e4e03 into master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants