Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS for Page Builder #1961

Merged
merged 5 commits into from
Nov 11, 2019
Merged

Add CODEOWNERS for Page Builder #1961

merged 5 commits into from
Nov 11, 2019

Conversation

davemacaulay
Copy link
Contributor

Description

Add CODEOWNERS for Page Builder

@davemacaulay davemacaulay added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 5, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Nov 5, 2019 •
edited
Loading

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against f3796c4

sirugh
sirugh previously approved these changes Nov 5, 2019
View reviewed changes
@sirugh
Copy link
Contributor

sirugh commented Nov 5, 2019

Oh, just to make sure, there's no other config/etc code that might fall under your umbrella?

@davemacaulay
Copy link
Contributor Author

@sirugh nope, all our code is within this directory, any other changes we made were just to help our stuff work :)

jimbo
jimbo suggested changes Nov 5, 2019
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
@davemacaulay @jimbo
Update .github/CODEOWNERS
5cbb290 
Co-Authored-By: Jimmy Sanford <[email protected]>
@davemacaulay
Copy link
Contributor Author

R.I.P @zetlen's & @jimbo's inbox

@jimbo
Copy link
Contributor

jimbo commented Nov 5, 2019

R.I.P @zetlen's & @jimbo's inbox

Perhaps. Let's let @zetlen chime in before attempting to merge this.

@jimbo
Unofficially denote codeowners
3a7a20c 
Individual code owners are only noted in this file for reference, so they're commented out. If an owner opts into notifications, that person can uncomment a line.
zetlen
zetlen approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've learned more about CODEOWNERS and I begrudgingly accept this as the right move.

@davemacaulay davemacaulay merged commit 855b06a into magento:develop Nov 11, 2019
@davemacaulay davemacaulay deleted the dave/codeowners branch November 11, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetlen zetlen zetlen approved these changes

@jimbo jimbo jimbo approved these changes

@sirugh sirugh sirugh left review comments

Assignees

@sirugh sirugh

@zetlen zetlen

@jimbo jimbo

Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davemacaulay @PWAStudioBot @sirugh @jimbo @zetlen