-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update devdocs dependencies #1957
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are still legitimate uses. Only links that use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not run the verification steps. (I really need to get that set up...)
I can if you need.
There's no need. @dpatil-magento has the docs environment set up and can verify |
Description
Updates the node and ruby dependencies for the
pwa-devdocs
site project.This PR also removes the
{{site.baseurl}}
prefixes from internal links since it is no longer required by Jekyll 4.Acceptance
@jcalcaben
Verification Stakeholders
@jcalcaben
Verification Steps
pwa-devdocs
directorybundle install && npm install
npm run build:production
_site
directory topwa-studio
:mv _site pwa-studio
_site
directory and movepwa-studio
into it:mkdir _site && mv pwa-studio _site
_site
:npx http-server _site
localhost:8080/pwa-studio
Screenshots / Screen Captures (if appropriate)
Checklist