Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same PHP version dependencies as Magento 2.3 #182

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Same PHP version dependencies as Magento 2.3 #182

merged 1 commit into from
Jul 31, 2018

Conversation

rowan-m
Copy link
Contributor

@rowan-m rowan-m commented Jul 30, 2018

This PR is a:

  • New feature
  • Enhancement/Optimization
  • Refactor
  • Bugfix
  • Test for existing code
  • Documentation

Summary

Composer cannot install the Venia theme in a PHP 7.2 environment. The assumption I've made here is that it's fine for the theme to have the same language requirements as Magento itself, i.e. https://github.com/magento/magento2/blob/2.3-develop/composer.json#L14

@rowan-m
Same PHP version dependencies as Magento 2.3
cb5aa88 
Composer cannot install the Venia theme in a PHP 7.2. The assumption I've made here is that it's fine for the theme to have the same language requirements as Magento itself, i.e. https://github.com/magento/magento2/blob/2.3-develop/composer.json#L14
@magento-cicd2
Copy link

magento-cicd2 commented Jul 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 326

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.873%
Totals Coverage Status
Change from base Build 324: 0.0%
Covered Lines: 890
Relevant Lines: 1618
💛 - Coveralls

@nuzil
Copy link

nuzil commented Jul 30, 2018

@Roman-M can you pleas sign an SLA?

@rowan-m
Copy link
Contributor Author

rowan-m commented Jul 30, 2018

@nuzil I'm just going through our internal Google processes on this one. Will update when I have more information.

@zetlen
Copy link
Contributor

zetlen commented Jul 30, 2018

Thanks, @rowan-m, good catch. Will merge pending CLA.

@rowan-m
Copy link
Contributor Author

rowan-m commented Jul 31, 2018

Internal corp checks approved, CLA signed.

@zetlen zetlen merged commit c6ef375 into magento:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetlen zetlen zetlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rowan-m @magento-cicd2 @coveralls @nuzil @zetlen