Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UAT: Styling for "Checkout" Button is Incorrect #694

Closed
7 tasks
awilcoxa opened this issue Dec 20, 2018 · 2 comments
Closed
7 tasks

UAT: Styling for "Checkout" Button is Incorrect #694

awilcoxa opened this issue Dec 20, 2018 · 2 comments
Labels
bug Something isn't working sustaining Marked for sustaining development.

Comments

@awilcoxa
Copy link

The current styling for the "Checkout" button in the right hand nav drawer (when items are added to cart) is incorrectly not in adherence to design.

Issue 10: https://wiki.corp.magento.com/display/FF/Venia+UX+Issues

Corrections to be applied:
"Medium" size
Dark gray
Fill style

This issue is for the following packages:

  • [x ] venia-concept
  • pwa-buildpack
  • [ x] peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec

This issue is a:

  • [ x] Bug
  • Feature suggestion
  • Documentation issue
  • Other (Please Specify)
@awilcoxa awilcoxa added bug Something isn't working sustaining Marked for sustaining development. labels Dec 20, 2018
@awilcoxa
Copy link
Author

Current Version:

image

Correct Version;

image

@AlexeyKaryka AlexeyKaryka mentioned this issue Dec 22, 2018
Merged
5 tasks
AlexeyKaryka added a commit to AlexeyKaryka/pwa-studio that referenced this issue Dec 22, 2018
@AlexeyKaryka
Some styles refactors to change common button color and size, change …
30164d6 
…color of required symbol in input, change color of kebab dropdown button, change color and text of forgot password link, update text above checkout button. Covers next issues: magento#689, magento#692, magento#687, magento#693, magento#688, magento#686, magento#694
@AlexeyKaryka AlexeyKaryka self-assigned this Dec 22, 2018
AlexeyKaryka added a commit to AlexeyKaryka/pwa-studio that referenced this issue Dec 22, 2018
@AlexeyKaryka
Some styles refactors to change common button color and size, change …
b5d1184 
…color of required symbol in input, change color of kebab dropdown button, change color and text of forgot password link, update text above checkout button. Covers next issues: magento#689, magento#692, magento#687, magento#693, magento#688, magento#686, magento#694
AlexeyKaryka added a commit to AlexeyKaryka/pwa-studio that referenced this issue Dec 26, 2018
@AlexeyKaryka
Some styles refactors to change common button color and size, change …
9ec39c4 
…color of required symbol in input, change color of kebab dropdown button, change color and text of forgot password link, update text above checkout button. Covers next issues: magento#689, magento#692, magento#687, magento#693, magento#688, magento#686, magento#694
@dmtrkad
Copy link

dmtrkad commented Jan 3, 2019

@jimbo , @supernova-at Could you please review it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sustaining Marked for sustaining development.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexeyKaryka @dmtrkad @awilcoxa