Skip to content

Commit

Permalink
Refactor and simplify PWADevServer host/port handling (#339)
Browse files Browse the repository at this point in the history
* refactor(buildpack): simplify secure host config

* fix(buildpack): simplify port and certificate handling

- chore: Remove hand-rolled implementations of privilege escalation and replace
with `devcert`.
- refactor: Remove individual options for SSL and unique host, combining them into
one thing.

Fixes #307.

fix: add new refactor to staging server

* fixup: package-lock

* fix errant package.json

* test fixing attempts

* fix: hoist deps to lower CI memory

* package updates for ci

* fix test

* fixup: PR feedback

* fixup

* fix: rename MAGENTO_BACKEND_DOMAIN to MAGENTO_BACKEND_URL

More accurately reflects the contents of the variable. Fixes #337.

* fixup

* fixup: CI errors

* fixup: more CI errors

* fixup: more CI errors again

* fixup: more CI errors yet again

* fix: better cache invalidation in CI
  • Loading branch information
zetlen committed Oct 9, 2018
1 parent bcbdd87 commit 449c52c
Show file tree
Hide file tree
Showing 39 changed files with 28,100 additions and 30,180 deletions.
7 changes: 3 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ common_settings:
- ~/.ssh
- ~/.npm
- /root/.npm
key: 'v3-npm-cache-{{ .Branch }}'
key: 'v3-npm-cache-{{ checksum "package-lock.json" }}'

install_latest_npm: &install_latest_npm
name: Ensure NPM is up to date
command: sudo npm install -g npm@latest

install_packages: &install_packages
name: Install NPM packages from lockfile
command: npm ci
command: npm ci --ignore-scripts && npx lerna bootstrap --hoist --no-ci

full_build: &full_build
name: Full Build
Expand Down Expand Up @@ -63,8 +63,7 @@ jobs:
- checkout
- restore_cache:
keys:
- 'v3-npm-cache-{{ .Branch }}'
- v3-npm-cache-
- 'v3-npm-cache-{{ checksum "package-lock.json" }}'
- run: *install_latest_npm
- run: *install_packages
- save_cache: *savecache
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Follow these steps to install the dependencies for all the packages in the proje
2. Navigate to the root of the repository from the command line
3. Run `npm install`
4. Copy `packages/venia-concept/example.env` to `packages/venia-concept/.env`
5. Uncomment the line for `MAGENTO_BACKEND_DOMAIN` in `packages/venia-concept/.env`, and set `MAGENTO_BACKEND_DOMAIN` to the fully-qualified URL of a Magento store running `2.3`.
5. Uncomment the line for `MAGENTO_BACKEND_URL` in `packages/venia-concept/.env`, and set `MAGENTO_BACKEND_URL` to the fully-qualified URL of a Magento store running `2.3`.
6. On your first install, run `npm run build` from package root.
7. To run the Venia storefront development experience, run `npm run watch:venia` from package root.

Expand Down
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
collectCoverageFrom: [
'scripts/**/*.js',
'src/**/*.js',
'lib/**/*.js',
'!**/__stories__/**',
'!**/__helpers__/**'
],
Expand Down
Loading

0 comments on commit 449c52c

Please sign in to comment.