Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional safety checks to insert/append card methods #94

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

mac-gallagher
Copy link
Owner

Ensures that the value returned from dataSource.numberOfCards(in cardStack: SwipeCardStack) is correct after the update.

@mac-gallagher mac-gallagher added the enhancement New feature or request label Jul 8, 2020
@mac-gallagher mac-gallagher self-assigned this Jul 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #94 into master will increase coverage by 0.5%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master     #94     +/-   ##
========================================
+ Coverage    83.1%   83.6%   +0.5%     
========================================
  Files          13      13             
  Lines         687     705     +18     
========================================
+ Hits          571     590     +19     
+ Misses        116     115      -1     
Impacted Files Coverage Δ
...Shuffle/SwipeCardStack/CardStackStateManager.swift 100.0% <100.0%> (ø)
...ources/Shuffle/SwipeCardStack/SwipeCardStack.swift 100.0% <100.0%> (+0.5%) ⬆️

@mac-gallagher mac-gallagher force-pushed the add-safety-checks branch 2 times, most recently from 36d74df to f193dd8 Compare July 8, 2020 03:40
@mac-gallagher mac-gallagher merged commit 1168aac into master Jul 8, 2020
@mac-gallagher mac-gallagher deleted the add-safety-checks branch July 8, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants