Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout provider classes #137

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

mac-gallagher
Copy link
Owner

@mac-gallagher mac-gallagher commented Apr 5, 2021

  • Remove LayoutProvider classes to simplify implementation
  • Add SwiftLint checks to ShuffleTests and ShuffleExample targets
  • Add Pods/ directory to .gitignore
  • Remove swipe/reverse swipe completion blocks in favor of calling directly in completion
  • Make code coverage checks non-blocking for PRs

@mac-gallagher mac-gallagher force-pushed the remove-layout-providers branch 2 times, most recently from e6b33e8 to 41293ce Compare April 5, 2021 21:07
@codecov-io
Copy link

codecov-io commented Apr 5, 2021

Codecov Report

Merging #137 (41293ce) into master (90adc0e) will decrease coverage by 0.7%.
The diff coverage is n/a.

❗ Current head 41293ce differs from pull request most recent head ccda241. Consider uploading reports for the commit ccda241 to get more accurate results

@@           Coverage Diff            @@
##           master    #137     +/-   ##
========================================
- Coverage    84.8%   84.1%   -0.8%     
========================================
  Files          13      11      -2     
  Lines         759     724     -35     
========================================
- Hits          644     609     -35     
  Misses        115     115             
Impacted Files Coverage Δ
...urces/Shuffle/Classes/SwipeCard/CardAnimator.swift 100.0% <ø> (ø)
Sources/Shuffle/Classes/SwipeCard/SwipeCard.swift 100.0% <ø> (ø)
Sources/Shuffle/Classes/SwipeCard/SwipeView.swift 100.0% <ø> (ø)
...ses/SwipeCardStack/CardStackAnimationOptions.swift 100.0% <ø> (ø)
...fle/Classes/SwipeCardStack/CardStackAnimator.swift 0.0% <ø> (ø)
...Classes/SwipeCardStack/CardStackStateManager.swift 100.0% <ø> (ø)
...huffle/Classes/SwipeCardStack/SwipeCardStack.swift 100.0% <ø> (ø)

@mac-gallagher mac-gallagher force-pushed the remove-layout-providers branch 3 times, most recently from dbebcc2 to 72a1ff3 Compare April 5, 2021 21:44
@mac-gallagher mac-gallagher merged commit 6182c78 into master Apr 5, 2021
@mac-gallagher mac-gallagher deleted the remove-layout-providers branch April 5, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants