Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deleteCards methods #109

Merged
merged 1 commit into from
Aug 1, 2020
Merged

add deleteCards methods #109

merged 1 commit into from
Aug 1, 2020

Conversation

mac-gallagher
Copy link
Owner

@mac-gallagher mac-gallagher commented Aug 1, 2020

  • Replaced deleteCard:atIndex and deleteCard:atPosition with deleteCards:atIndices and deleteCards:atPositions methods
  • Add swipedCards -> [Int] method

Closes #103

@mac-gallagher mac-gallagher added the enhancement New feature or request label Aug 1, 2020
@mac-gallagher mac-gallagher self-assigned this Aug 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2020

Codecov Report

Merging #109 into master will increase coverage by 0.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #109     +/-   ##
========================================
+ Coverage    84.4%   84.8%   +0.3%     
========================================
  Files          13      13             
  Lines         740     759     +19     
========================================
+ Hits          625     644     +19     
  Misses        115     115             
Impacted Files Coverage Δ
...Shuffle/SwipeCardStack/CardStackStateManager.swift 100.0% <100.0%> (ø)
...ources/Shuffle/SwipeCardStack/SwipeCardStack.swift 100.0% <100.0%> (ø)

@mac-gallagher mac-gallagher force-pushed the deleteAll branch 2 times, most recently from 1b9ff3e to 12ae611 Compare August 1, 2020 23:05
@mac-gallagher mac-gallagher marked this pull request as ready for review August 1, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deleteCards: method
2 participants