Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index fixes #647

Merged
merged 2 commits into from
Feb 17, 2015
Merged

Index fixes #647

merged 2 commits into from
Feb 17, 2015

Conversation

FabianOvrWrt
Copy link
Contributor

This fixes some spacing issues with the ticks (they are cut out) and a height issue, where the Info tab text is not fully visible on small screens.

This was tested on Alcatel One Touch Fire C (Firefox OS 1.3) and One Touch Fire (Firefox 1.4 - 2.1) and I don't know if this creates another problem in other phones.

@TitanNano
Copy link
Contributor

no, they are not cut off.
It's a gecko rendering bug. I already tested it on my Peak cause I had the same problem.

But I'll test this patch later an see if it changes something.

@FabianOvrWrt
Copy link
Contributor Author

I don't know if the problem with the ticks is just for these phones, I saw it on the Fire C and I though that it was just a problem with Firefox OS 1.3, but I've tested Loqui on every Firefox OS version possible on the One Touch Fire and I get the same problem.

You may not be able to reproduce the Info tab text issue because the text itself should fit without scrolling on the Peak, since it has a larger screen, this just fixes the problem with HVGA screen phones.

@TitanNano
Copy link
Contributor

Hmmm, on my peak the second tick is also cut off until the next re render.
I played around with the spacing and it didn't change anything. But I'll
see if your patch changes anything for me...

2015-02-17 17:15 GMT+01:00 Fabián PS [email protected]:

I don't know if the problem with the ticks is just for these phones, I saw
it on the Fire C and I though that it was just a problem with Firefox OS
1.3, but I've tested Loqui on every Firefox OS version possible on the One
Touch Fire and I get the same problem.

You may not be able to reproduce the Info tab text issue because the text
itself should fit without scrolling on the Peak, since it has a larger
screen, this just fixes the problem with HVGA screen phones.


Reply to this email directly or view it on GitHub
#647 (comment).

@gargsms
Copy link
Member

gargsms commented Feb 17, 2015

I can confirm that the ticks are not getting placed at the proper place in Flame with Firefox OS v2.

@TitanNano
Copy link
Contributor

hmm okay I'll test the patch now.

2015-02-17 20:45 GMT+01:00 Sukant Garg [email protected]:

I can confirm that the ticks are not getting placed at the proper place in
Flame with Firefox OS v2.


Reply to this email directly or view it on GitHub
#647 (comment).

TitanNano pushed a commit that referenced this pull request Feb 17, 2015
@TitanNano TitanNano merged commit c3d7598 into loqui:dev Feb 17, 2015
@TitanNano
Copy link
Contributor

I couldn't see any difference on my device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants