Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segmented buf len implementation #11

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Fix segmented buf len implementation #11

merged 3 commits into from
Mar 29, 2021

Conversation

c-nixon
Copy link
Collaborator

@c-nixon c-nixon commented Mar 23, 2021 •
edited
Loading

Replace old, underestimating len function

@c-nixon c-nixon requested a review from jorgebay March 23, 2021 09:55
@c-nixon c-nixon changed the title Delegate segmented buf len to Buf implementation Fix segmented buf len implementation Mar 23, 2021
@c-nixon c-nixon changed the base branch from main to 0.4.x March 23, 2021 10:28
jorgebay
jorgebay approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@jorgebay jorgebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@c-nixon c-nixon merged commit 09a8aea into 0.4.x Mar 29, 2021
@c-nixon c-nixon deleted the fix-segmented-buf-len branch March 29, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgebay jorgebay jorgebay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-nixon @jorgebay