Split projects into proj4j and proj4j-epsg #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
added a commit
that referenced
this pull request
Dec 4, 2022
* Split projects into two, update HOWTORELEASE instructions as well as the related set of mvn plugins * Bump the default proj4j snapshot version up
TomasJohansson
added a commit
to TomasJohansson/crsTransformations
that referenced
this pull request
Jan 5, 2023
… version 1.2.2, and generated a new output csv file "CrsTransformationAdapterProj4jLocationtech_version_1.2.2.csv" with lots of coordinate transformations created by this new version, which can be compared (e.g. by using WinMerge) with the csv file from the previously used version i.e. the csv file "CrsTransformationAdapterProj4jLocationtech_version_1.1.4.csv" (and there were no differences) Also added a new dependency "proj4j-epsg" and updated the license text because of this new dependency. Below is some text copied from https://github.com/locationtech/proj4j : "Important! As of 1.2.2 version, proj4-core contains no EPSG Licensed files. In order to make proj4j properly operate, it makes sense to consider proj4-epsg dependency usage." Some related "locationtech/proj4j" issues and pull requests: "Proj4j should not use the Apache License if it contains the EPSG data set" locationtech/proj4j#90 "Split projects into proj4j and proj4j-epsg" locationtech/proj4j#92 "Move all core resources to epsg submodule" locationtech/proj4j#95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out to be that EPSG licensed files are in the resources folder historically, and not used by the code of this project. This is a historical artifact appeared here after the
geotrellis-proj4jproject split.However, I still think it makes sense to release these resources under a separate
proj4j-epsgproject, these files are still used by the GeoTrellis project.Linked #90
cc @julianhyde, @desruisseaux, @jnh5y, and @echeipesh