Implement setRadius #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @skinkie thanks for your contribution I'll merge it ASAP! And gz with your first contribution into this project! Could you please sign an ECA? https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla After that run in your terminal: git commit --amend -s && git push origin -f feature_setRadius |
A projection may have a radius. This commit implements setRadius used in for example Equidistant Cylindrical where: +R=<value> Radius of the sphere given in meters. As per documentation this function is applied on the end, so it takes precedence over +ellps. Signed-off-by: Stefan de Konink <[email protected]>
skinkie
force-pushed
the
feature_setRadius
branch
from
9e8fc94
to
145dfce
Compare
|
@pomadchin it would help me greatly if you could also push out a new release having this on board, so I can directly use it in my own projects. |
|
@pomadchin is there anything you still require from me? |
pomadchin
approved these changes
Dec 14, 2019
|
hey @skinkie; we plan to publish a new release during the next couple of weeks (I hope before holidays) Thanks again for contributing! |
|
Thank you for bringing proj4j back to active development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A projection may have a radius. This commit implements setRadius used in for example Equidistant Cylindrical where:
+R= Radius of the sphere given in meters. As per documentation this function is applied on the end, so it takes precedence over +ellps.
Fix #54