Minor hashCode/equals override improvements #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quals(), and should not override hashCode(). The isEqual() method could be renamed or rewritten to override equals, but is currently does not. Added hashCode() override to Unit class and Pair class. Added override annotations to Ellipsoid class for clarity. Signed-off-by: neutlamberink <[email protected]>
pomadchin
approved these changes
Sep 24, 2019
| @@ -265,9 +265,4 @@ public void shift(ProjCoordinate xy) { | |||
| public void inverseShift(ProjCoordinate xy) { | |||
| Grid.shift(grids, true, xy); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
👍 equals is not overrided, so we don't need a hashCode function override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: neutlamberink [email protected]