-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace secp256k1 to @noble/secp256k1 #22
chore: replace secp256k1 to @noble/secp256k1 #22
Conversation
@aaronbarnardsound please review this :) |
Thanks for this @im-adithya and awesome work! I added a couple of commits to format and bump the version as well as changing the target branch to develop. I am going to merge this and will look at publishing a release soon. I am just waiting on another change that I want to get in to the next release as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Hey @im-adithya it seems like the separate Noble packages (secp256k1) should be upgraded to the noble-curves package. See here: https://github.com/paulmillr/noble-curves#upgrading. Would you be up for creating a new PR that switches to that instead? |
We don't have any other curves being used in this repository, right? That would increase the size unnecessarily (Unless you plan to expand?) |
Yep there aren't any other curves being used and no plans to use other curves. My reading of that upgrade section was that the curves library included the latest and fastest implementation of secp256k1, but after reading further I am not sure! |
Replaced the entire library, also was able to make up for the method which wasn't available in @noble/secp256k1
Fixes #21