Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace secp256k1 to @noble/secp256k1 #22

Merged

Conversation

im-adithya
Copy link
Contributor

@im-adithya im-adithya commented Mar 6, 2023

Replaced the entire library, also was able to make up for the method which wasn't available in @noble/secp256k1

Fixes #21

@im-adithya
Copy link
Contributor Author

@aaronbarnardsound please review this :)

@lnbc1QWFyb24 lnbc1QWFyb24 changed the base branch from master to develop March 7, 2023 02:14
@lnbc1QWFyb24
Copy link
Owner

Thanks for this @im-adithya and awesome work! I added a couple of commits to format and bump the version as well as changing the target branch to develop. I am going to merge this and will look at publishing a release soon. I am just waiting on another change that I want to get in to the next release as well.

Copy link
Owner

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 5469c11 into lnbc1QWFyb24:develop Mar 7, 2023
@lnbc1QWFyb24
Copy link
Owner

Hey @im-adithya it seems like the separate Noble packages (secp256k1) should be upgraded to the noble-curves package. See here: https://github.com/paulmillr/noble-curves#upgrading.

Would you be up for creating a new PR that switches to that instead?

@im-adithya
Copy link
Contributor Author

We don't have any other curves being used in this repository, right? That would increase the size unnecessarily (Unless you plan to expand?)

@lnbc1QWFyb24
Copy link
Owner

Yep there aren't any other curves being used and no plans to use other curves. My reading of that upgrade section was that the curves library included the latest and fastest implementation of secp256k1, but after reading further I am not sure!
I believe since it is an ESM module all the other modules will not be included in the bundle due to tree shaking so I don't think size will be an issue, but we can just leave it as is for now.

@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace secp256k1 with @noble/secp256k1
2 participants