[libcxx][test] Mark sort.pass.cpp as a long test #100720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picolib testing skips any test requiring this feature, I just didn't know the feature existed until now.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: David Spickett (DavidSpickett) ChangesPicolib testing skips any test requiring this feature, I just didn't know the feature existed until now. Full diff: https://github.com/llvm/llvm-project/pull/100720.diff 1 Files Affected:
diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
index da7794e8c85dc..9bd28140349b6 100644
--- a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
@@ -8,7 +8,7 @@
// This test did pass but is very slow when run using qemu. ~7 minutes on a
// Neoverse N1 (AArch64) server core.
-// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
+// REQUIRES: long_tests
// <algorithm>
|
|
It could be |
ldionne
approved these changes
Jul 31, 2024
clementval
pushed a commit
to clementval/llvm-project
that referenced
this pull request
Jul 31, 2024
Picolib testing skips any test requiring this feature, I just didn't know the feature existed until now.
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
Picolib testing skips any test requiring this feature, I just didn't know the feature existed until now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picolib testing skips any test requiring this feature, I just didn't know the feature existed until now.