Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Brush Color Settings #1538

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

Haoming02
Copy link
Contributor

  • Right now, the 3 brush color options in Settings -> img2img are not used at all. So I add them back to the ForgeCanvas to make them function again.
  • Also added a new option to toggle between the high-contrast brush and the color brush for the Inpaint mode, as some users may feel uncomfortable with the checked pattern ( How change the Inpaint to use color brush again?🤔 #1528 )

@DenOfEquity
Copy link
Collaborator

DenOfEquity commented Aug 27, 2024

Nice one, works well.
I'd argue for including scribble_color_fixed=True, scribble_alpha_fixed=True, scribble_softness_fixed=True on the Inpaint canvas.

edit:
As it turns out, I can make those changes.
Thank for PR, Haoming02.

hide the color/opacity/softness controls on the inpaint tab:
consistent with high contrast option + 
they don't offer real control anyway (color irrelevant to mask, mask gets thresholded to binary)
@DenOfEquity DenOfEquity merged commit 69ffe37 into lllyasviel:main Aug 31, 2024
@Haoming02
Copy link
Contributor Author

scribble_color_fixed=True, scribble_alpha_fixed=True, scribble_softness_fixed=True

imho it is better to let the user change those parameters. Disabling those kinda defeats the point of using ForgeCanvas ...

now you never worry about brush color being invisible when it is similar to image color ( #853 )

One of the advantages of ForgeCanvas is that you can draw a mask on a white/bright image, without losing where the mask is.

@Haoming02 Haoming02 deleted the inpaint-brush-option branch September 3, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants