-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: use render output per session instead of global #826
Conversation
looks like a smart idea |
@lllyasviel now includes the code adjustments to automatically stop previous abandoned tasks |
@lllyasviel is it realistic for the changes to be reviewed until end of this week? |
will be handled in one next version |
# Conflicts: # modules/async_worker.py
@lllyasviel I try to keep this MR up-to-date as this is a dealbreaker for multiuser access. Having the feature allows for separate sessions which is mandatory especially when LCM is too fast for the Gradio UI to keep up and users leave the page before the UI thread has finished. |
# Conflicts: # modules/async_worker.py # webui.py
0dfb287
to
a7f2dfe
Compare
…ess starts fix inconsistency in behaviour of stop_button and skip_button as sometimes it was possible to skip or stop other users processes while still being in queue
unfortunatly this looks a bigger problem and we need to use other ways to fix it. some algorithmic vars are also global. |
As currently only one task is processed at a time they may not impact user experience in any / a significant way as resetting them in between jobs should be sufficient. |
added in 2.1.821 |
The only remaining behavioural difference is now that tasks will still be processed when the tab is closed / page is reloaded / connection breaks, but this could also be an intended feature as one could queue a large number of images and expect them to be saved to storage, but then closes the tab. generate_clicked
async_worker
I assume the current behaviour is intended and will close this PR. |
@lllyasviel + another issue still remained which was fixed in this PR, now in a separate MR, see #981 |
fixes #713, #501
Use state for worker_outputs in webui and work with parameter in async_worker instead of global outputs.
Tested and working, now shows "initializing" when the other window has been reloaded/closed and WS connection was closed.
@lllyasviel We might optimize this by setting skip_prompt_processing = true until the current render job is started.