Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UX Colorize aspect ratios, landscape vs portrait #2926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeonglow
Copy link

I found trying to guess if the Aspect Ration was landscape or portrait. Kept getting it wrong! As my computer is super old and slow, this bugged me.

My original idea was to split the manual in three, but that was a hassle to implement without changing a lot of things. This seemed pretty straight forward.

I'm so lazy I didn't add a key, but that would just create more work for localization and it's pretty clear

Screenshot
image

@zeonglow zeonglow requested a review from lllyasviel as a code owner May 15, 2024 13:22
@mashb1t mashb1t added the Size S small change, basically no testing needed label Jun 4, 2024
@andynormancx
Copy link

andynormancx commented Jun 5, 2024

It feels to me that this is crying out for a little bit of SVG magic to draw the aspect ratio next to each option.

Or probably just some HTML/CSS. Though possibly the differences in aspect ration will be hard to see at this size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants