Add VAE select #2867
Merged
Add VAE select #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
csokun
pushed a commit
to csokun/Fooocus
that referenced
this pull request
Jun 16, 2024
* Revert "fix: use LF as line breaks for Docker entrypoint.sh (lllyasviel#2843)" (lllyasviel#2865) False alarm, worked as intended before. Sorry for the fuzz. This reverts commit d16a54e. * feat: add VAE select * feat: use different default label, add translation * fix: do not reload model when VAE stays the same * refactor: code cleanup * feat: add metadata handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1840 (@E2GO fyi)
as discussed in #2861 (@ILikeToasters fyi)
Adds a dropdown for model VAE, which is especially handy when the base model doesn't have one baked in.
Upload VAEs to the already existing models/vae folder.
IMPORTANT: not models/vae_approx, which is used for the preview of intermediate step images with fixed VAE
Open TODO's:
notcrash on startup when default_vae is not in list of vae_filenamesTested with model Mohawk (any other model with no VAE baked in will work for testing too)
Before:
washed out look, desaturated
Details
(EDIT screenshot with different model, see exact resulting image below)
After:
selected VAE is applied, colorful image
Details