added the download model from url feature #2423

codezeros · 2024-03-03T11:03:43Z

support all downloadable urls

Models can be downloaded simply by copying and pasting their URLs.

codezeros · 2024-03-03T11:56:10Z

mashb1t

General feedback: thank you for the implementation, this can be very useful if people don't know the file structure.

Code feedback:

do not spam code comments for trivial things, as mentioned.
do not autoformat whole files on existing projects, only your part of the implementation.
add translations for every outpout, every message, etc. to en.json
add argument for disabling the whole tab as not everyone wants/needs/allows users to download newc models, such as on hosted environments, as this may cause a huge increase in traffic (=> more costs) and may be abused, especially in a multi-user environment.

Looking forward to your adjustments.

modules/download_models.py

modules/load_paths.py

modules/download_models.py

webui.py

codezeros · 2024-03-03T18:02:54Z

General feedback: thank you for the implementation, this can be very useful if people don't know the file structure.

Code feedback:

* do not spam code comments for trivial things, as mentioned.

* do not autoformat whole files on existing projects, only your part of the implementation.

* add translations for every outpout, every message, etc. to en.json

* add argument for disabling the whole tab as not everyone wants/needs/allows users to download newc models, such as on hosted environments, as this may cause a huge increase in traffic (=> more costs) and may be abused, especially in a multi-user environment.

Looking forward to your adjustments.

@mashb1t thank you for your feedback
i have now removed unnecessary comments and make the codebase simple and effective and we can set the path now directly in json config file instead of dynamically generate json on start of app each time run.

if there any other that need to improve feel free to tell me :)

mashb1t

keep in mind to add the translations to en.json as well as add an argument to completely not render the output for all elements when set.
Argument can be --disable-download-tab or similar. You can orient yourself on --disable-metadata + all occurrences of args_manager.args.disable_metadata in the code

modules/download_models.py

modules/model_loader.py

webui.py

uptotec · 2024-03-04T13:07:05Z

hi! if you can only download from civitAI you can get the filename and folder from the api. civitai provide array of files the first one is always the model file. the api also give you the model type you can select the folder based on the model type.

codezeros · 2024-03-04T13:22:01Z

hi! if you can only download from civitAI you can get the filename and folder from the api. civitai provide array of files the first one is always the model file. the api also give you the model type you can select the folder based on the model type.

@uptotec yes, for that we need to add store feature using civitai api but this is for downloading models directly into the application using url only also i have tested with huggingface and civitai urls and some other it works! without any issues but note that some model may have sign-in access restriction for those we can not download directly just with url alone

codezeros · 2024-03-04T15:00:18Z

@mashb1t i have modified according to your suggestion and also we can disable download tab using argument --disable-download-tab and also using checkbox in debug (still in progress any suggestions would help!) and added translation :)

mashb1t · 2024-03-04T15:05:07Z

@codezeros thanks for the update, much appreciated. Will do the review during this week.
I'm wondering, which benefit would it have to be able to toggle the tab in the developer debug settings?

codezeros · 2024-03-04T15:10:42Z

@codezeros thanks for the update, much appreciated. Will do the review during this week. I'm wondering, which benefit would it have to be able to toggle the tab in the developer debug settings?

@mashb1t i thought user can also disable the tab in fooocus itself to simply make the config easier for non-tech users which may help

…_model_from_url_feature

mashb1t · 2024-03-05T21:25:26Z

webui.py

@@ -433,6 +453,7 @@ def update_history_link():
                        disable_seed_increment = gr.Checkbox(label='Disable seed increment',
                                                             info='Disable automatic seed increment when image number is > 1.',
                                                             value=False)
+                        disable_download_checkbox = gr.Checkbox(label='Disable Download Tab',info='Disable the download tab when clicked',value=modules.config.default_download_tab_checkbox,elem_classes='min_check')


set interactive to false when arg is set

mashb1t · 2024-03-05T21:25:44Z

webui.py

@@ -541,6 +562,9 @@ def model_refresh_clicked():
        advanced_checkbox.change(lambda x: gr.update(visible=x), advanced_checkbox, advanced_column,
                                 queue=False, show_progress=False) \
            .then(fn=lambda: None, _js='refresh_grid_delayed', queue=False, show_progress=False)
+        disable_download_checkbox.change(lambda x: gr.update(visible=x), disable_download_checkbox, download_tab) \


do not process/output when arg is true

mashb1t · 2024-03-05T21:30:10Z

webui.py

@@ -332,6 +333,25 @@ def update_history_link():
                                                       show_progress=False).then(
                    lambda: None, _js='()=>{refresh_style_localization();}')

+            if not args_manager.args.disable_download_tab:
+                    with gr.Tab(label='Download',visible=modules.config.default_download_tab_checkbox)as download_tab:


Suggested change

with gr.Tab(label='Download',visible=modules.config.default_download_tab_checkbox)as download_tab:

with gr.Tab(label='Download', visible=modules.config.default_download_tab_checkbox) as download_tab:

mashb1t · 2024-03-05T21:34:50Z

modules/config.py

-path_controlnet = get_dir_or_set_default('path_controlnet', '../models/controlnet/')
-path_clip_vision = get_dir_or_set_default('path_clip_vision', '../models/clip_vision/')
-path_fooocus_expansion = get_dir_or_set_default('path_fooocus_expansion', '../models/prompt_expansion/fooocus_expansion')
+config_paths = {


please do it the other way round.
Instead of using an array and then assigning variables with keys it's more robust to assign variables first and then build an array from vars. This eliminates the need for array key string reading.

mashb1t · 2024-03-05T21:36:32Z

modules/config.py

@@ -318,6 +347,11 @@ def get_config_item_or_set_default(key, default_value, validator, disable_empty_
    default_value=False,
    validator=lambda x: isinstance(x, bool)
 )
+default_download_tab_checkbox = get_config_item_or_set_default(


please use a more descriptive naming here, e.g. default_show_download_tab

xhoxye · 2024-03-06T00:35:27Z

Some personal advice:

You can list the fooocus's built-in model download links in downloadtab and add other backup download links. Select Download through the drop-down option to solve the problem of model download failure when fooocus is started.
For Civitai, you can refresh the update of the model version

mashb1t · 2024-03-09T15:19:55Z

modules/model_loader.py

+            from torch.hub import download_url_to_file
+            download_url_to_file(url, cached_file, progress=progress)
+        except Exception as e:
+            print(f"Failed to download \"{url}\" to {cached_file}, reason : {e}")


@codezeros downloading an invalid URL still reports as successful to the frontend despite raising an exception.
This has to be fixed (reverted).

Failed to download "invalid url" to /Volumes/data/private/development/ai/fooocus/models/checkpoints/invalid url, reason : unknown url type: 'invalid url'

@mashb1t thanks for notifying the problem i will look into it and also making some improvements based on previous feedback (in progress)

sd-jack · 2024-07-07T13:35:10Z

That's enhancement is great! Thank you @codezeros

added the download_model_from_url_feature

d7ad69f

codezeros requested a review from lllyasviel as a code owner March 3, 2024 11:03

Merge branch 'main' into download_model_from_url_feature

47eddef

mashb1t requested changes Mar 3, 2024

View reviewed changes

mashb1t added the Size M medium change, isolated, testing with care label Mar 3, 2024

removed unwanted comments and reduced codebase simpler

af13c46

codezeros added 2 commits March 3, 2024 23:38

fixed the codebase formatted

b07057a

fixed the codebase formatted remaining

8421440

codezeros requested a review from mashb1t March 3, 2024 18:18

mashb1t requested changes Mar 3, 2024

View reviewed changes

mashb1t mentioned this pull request Mar 3, 2024

Colab: added the ability to download models from civitai #1758

Open

codezeros added 2 commits March 4, 2024 19:01

added disable download tab using argument

eb35281

fixed for previous commit

4820f31

codezeros force-pushed the download_model_from_url_feature branch from 64751d8 to 4820f31 Compare March 4, 2024 14:42

added translations to en.json

56d0af5

codezeros requested a review from mashb1t March 4, 2024 14:55

Merge remote-tracking branch 'refs/remotes/origin/main' into download…

35ec483

…_model_from_url_feature

mashb1t requested changes Mar 5, 2024

View reviewed changes

mashb1t reviewed Mar 9, 2024

View reviewed changes

mashb1t added the feedback pending Waiting for further information label Mar 9, 2024

mashb1t added feedback pending Waiting for further information and removed feedback pending Waiting for further information labels Jun 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added the download model from url feature #2423

added the download model from url feature #2423

codezeros commented Mar 3, 2024

codezeros commented Mar 3, 2024

mashb1t left a comment

codezeros commented Mar 3, 2024 •

edited

Loading

mashb1t left a comment

uptotec commented Mar 4, 2024

codezeros commented Mar 4, 2024

codezeros commented Mar 4, 2024 •

edited

Loading

mashb1t commented Mar 4, 2024

codezeros commented Mar 4, 2024

mashb1t Mar 5, 2024

mashb1t Mar 5, 2024

mashb1t Mar 5, 2024

mashb1t Mar 5, 2024

mashb1t Mar 5, 2024

xhoxye commented Mar 6, 2024 •

edited

Loading

mashb1t Mar 9, 2024

codezeros Mar 9, 2024

sd-jack commented Jul 7, 2024

	with gr.Tab(label='Download',visible=modules.config.default_download_tab_checkbox)as download_tab:
	with gr.Tab(label='Download', visible=modules.config.default_download_tab_checkbox) as download_tab:

added the download model from url feature #2423

Are you sure you want to change the base?

added the download model from url feature #2423

Conversation

codezeros commented Mar 3, 2024

codezeros commented Mar 3, 2024

mashb1t left a comment

Choose a reason for hiding this comment

codezeros commented Mar 3, 2024 • edited Loading

mashb1t left a comment

Choose a reason for hiding this comment

uptotec commented Mar 4, 2024

codezeros commented Mar 4, 2024

codezeros commented Mar 4, 2024 • edited Loading

mashb1t commented Mar 4, 2024

codezeros commented Mar 4, 2024

mashb1t Mar 5, 2024

Choose a reason for hiding this comment

mashb1t Mar 5, 2024

Choose a reason for hiding this comment

mashb1t Mar 5, 2024

Choose a reason for hiding this comment

mashb1t Mar 5, 2024

Choose a reason for hiding this comment

mashb1t Mar 5, 2024

Choose a reason for hiding this comment

xhoxye commented Mar 6, 2024 • edited Loading

mashb1t Mar 9, 2024

Choose a reason for hiding this comment

codezeros Mar 9, 2024

Choose a reason for hiding this comment

sd-jack commented Jul 7, 2024

codezeros commented Mar 3, 2024 •

edited

Loading

codezeros commented Mar 4, 2024 •

edited

Loading

xhoxye commented Mar 6, 2024 •

edited

Loading