Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically describe image on uov image upload #1938

Merged

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented Jan 15, 2024

Describes the uploaded image if prompt is empty (prevents prompt override).
This allows for better results by inexperienced users as they do not have to write a prompt from scratch when creating variations + it saves a few steps.

@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 9, 2024
@aolko
Copy link

aolko commented Apr 24, 2024

when this is going to be merged?

@mashb1t
Copy link
Collaborator Author

mashb1t commented Apr 24, 2024

i'm normally not keen on merging my own suggested features without review, and this one is exactly that, a suggestion. Not necessarily needed, but can be helpful.
For it to be merged i'm open to suggestions if people of the community or @lllyasviel think this improves the current situation.
Happy to hear some feedback!

@aolko
Copy link

aolko commented Apr 24, 2024

i'm normally not keen on merging my own suggested features without review, and this one is exactly that, a suggestion. Not necessarily needed, but can be helpful. For it to be merged i'm open to suggestions if people of the community or @lllyasviel think this improves the current situation. Happy to hear some feedback!

I suggest this feature being in vanilla fooocus, as it is an essential must have

@mashb1t
Copy link
Collaborator Author

mashb1t commented May 17, 2024

@aolko i've added an argument --enable-describe-uov-image, which can be set to enable the behaviour by default.
This prevents computers with low hardware specifications from being unnecessary blocked.

@mashb1t mashb1t changed the base branch from main to develop May 17, 2024 16:21
@mashb1t mashb1t changed the base branch from develop to main May 17, 2024 16:24
@mashb1t mashb1t changed the base branch from main to develop May 17, 2024 16:24
@mashb1t mashb1t merged commit 33fa175 into lllyasviel:develop May 17, 2024
@mashb1t mashb1t added this to the 2.4.0 milestone May 17, 2024
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
* feat: automatically describe image on uov image upload if prompt is empty

* feat: add argument to disable automatic uov image description

* feat: rename argument, disable by default

this prevents computers with low hardware specifications from being unnecessary blocked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants