Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates readme to use consistent python3 version #1098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hamma111
Copy link

@Hamma111 Hamma111 commented Dec 1, 2023

The same python version should be consistently used. Right now, we could be using a different python version to set up the venv but another python to install requirements and running the scripts.

While this is an uncommon scenario, but still might be relevant for a lot of scenarios.

Breakdown of the issue:

  1. Virtual Env was being created using python3 but all the subsequent commands utilize the python
  2. In most cases, python and python3 could be referencing to different python versions.
  3. We should be using the same python command we created the venv with i.e. python3

Copy link

@Stephanvs Stephanvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 9, 2024
@mashb1t mashb1t added the documentation Improvements or additions to documentation label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants