Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add advanced parameter for disable_intermediate_results (progress_gallery) #1013

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented Nov 22, 2023

Fixes #948

prevents gradio frontend process from clogging image output of progress_gallery in high throughput scenarios such as LCM with image number >= 4

prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4
based on default and selected performance
@pscheit
Copy link

pscheit commented Jan 17, 2024

Tested this commit directly the last few days: It works to not show the intermediate results as expected.

But it doesnt help to work around the UI issues (linked in the mentioning issues). UI still hangs and shows errors / times out.

Maybe there is just on button needed "Reconnect to Websocket" somewhere. Cause when the UI hangs in the wrong state you only can do a full reload and lose all your settings.

@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 9, 2024
…ble-intermediate-images

# Conflicts:
#	modules/advanced_parameters.py
@mashb1t mashb1t added this to the 2.2.0 milestone Feb 24, 2024
@mashb1t mashb1t changed the base branch from main to develop February 24, 2024 18:04
…termediate-images

# Conflicts:
#	modules/advanced_parameters.py
#	webui.py
@mashb1t mashb1t merged commit a841e91 into lllyasviel:develop Feb 24, 2024
mashb1t added a commit that referenced this pull request Feb 25, 2024
…ss_gallery) (#1013)

* add advanced parameter for disable_intermediate_results

prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4

* update disable_intermediate_results correctly

based on default and selected performance

* chore: add missing translations
mashb1t added a commit that referenced this pull request Feb 25, 2024
…ss_gallery) (#1013)

* add advanced parameter for disable_intermediate_results

prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4

* update disable_intermediate_results correctly

based on default and selected performance

* chore: add missing translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extreme Speed is very fast,but the Gradio progress bar can't keep up with the speed of image generation
2 participants