Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransferParticipant to sip and sip internal services #816

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

biglittlebigben
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: b66dd61

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@biglittlebigben
Copy link
Contributor Author

Current implementation is for the RPC to wait until the transfer succeeds or fails (ie until the new peer picks up the phone). This means that there is no transfer status API/attributes on the participant. The transfer can take longer than the default RPC timeout though, so this may or may not be the way we want to go eventually.

@biglittlebigben biglittlebigben merged commit 71b9c18 into main Sep 20, 2024
3 checks passed
@biglittlebigben biglittlebigben deleted the benjamin/transfer_sip branch September 20, 2024 18:47
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants