Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass additional metadata for SIP #696

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Pass additional metadata for SIP #696

merged 1 commit into from
Apr 26, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Apr 25, 2024

Add metadata for SIP:

  • Human-friendly name for SIP Trunks and Dispatch Rules.
  • Custom user metadata for all SIP objects. Metadata set on Dispatch Rules will be inherited by SIP participant created by the rule.
  • Add SIP Call ID, for better logging and tracing.
  • Methods like EvaluateSIPDispatchRule will now return a Trunk and Dispatch Rule ID used.

There's one potentially breaking change: previously SIP participants had Phone prefix for both participant name and identity. Now identity will have a shorter sip_ prefix. Name will still be the same.

Since some users parse phone number from one of these, we need to notify them about the change and make sure they use name instead of identity. Future change will add cleaner way for getting SIP number for a participant.

@dennwc dennwc self-assigned this Apr 25, 2024
Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: e553b08

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc merged commit e7962f4 into main Apr 26, 2024
3 checks passed
@dennwc dennwc deleted the sip-metadata branch April 26, 2024 10:44
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants