WHIP protocol change #680
Merged
WHIP protocol change #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e291e98 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
biglittlebigben
force-pushed
the
benjamin/whip_passthrough
branch
from
1e15c88
to
ded242a
Compare
dennwc
approved these changes
Apr 23, 2024
|
Also please don't forget to add a changeset! |
frostbyte73
reviewed
Apr 23, 2024
protobufs/livekit_ingress.proto
Outdated
| @@ -113,6 +113,9 @@ message IngressVideoEncodingOptions { | |||
| repeated VideoLayer layers = 3; | |||
| } | |||
|
|
|||
| message IngressVideoEncodingPassthrough { | |||
There was a problem hiding this comment.
Leftover from a previous version. I removed it. Thanks.
davidzhao
reviewed
Apr 24, 2024
| // whether to pass through the incoming media without transcoding, only compatible with some input types | ||
| bool bypass_transcoding = 8; | ||
| bool bypass_transcoding = 8 [deprecated = true]; | ||
| optional bool enable_transcoding = 11; |
There was a problem hiding this comment.
can we add docstring here explaining the nuance of this param?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional "enable_transcoding" entry to the ingress APIs and deprecates the bypass_transcoding entry. This is in preparation of disabling "enable_transcoding" by default for WHIP.