Remove unused SIP participant APIs #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
approved these changes
Jan 19, 2024
dennwc
force-pushed
the
simplify_sip_participant
branch
2 times, most recently
from
911ce90
to
1f2fce0
Compare
dennwc
force-pushed
the
simplify_sip_participant
branch
from
1f2fce0
to
110c2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused SIP participant APIs. Only keep the API for creating SIP participants. Return regular
ParticipantInfofrom it.This will break compatibility for that specific method if CLI and server versions are different. But as far as we know outbound calling is not used for any project yet.
DO NOT MERGE! I want to propagate the change locally first to see if it fits right.