Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exponential backoff in egress RPC client retry logic #545

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

biglittlebigben
Copy link
Contributor

This uses exponential increases for both the timeout and backoff parameters. The formula is for the increase is:

base * 2 ^ (attempt - 1) * rand[1,2)

This means that for the different attempts, we get:

1: base * [1-2)
2: base * [2-4)
3: base * [4-8)
4: base * [8-16)
...

@biglittlebigben
Copy link
Contributor Author

Thinking about this again, there is no reason to have a random component to the timeout parameter. Will change this.

@biglittlebigben biglittlebigben merged commit b5b0839 into main Dec 13, 2023
3 checks passed
@biglittlebigben biglittlebigben deleted the benjamin/egress_rpc_retry branch December 13, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants