Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SIP rules evaluation from LiveKit server #534

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Move SIP rules evaluation from LiveKit server #534

merged 1 commit into from
Nov 30, 2023

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Nov 30, 2023

No description provided.

@dennwc dennwc requested a review from Sean-Der November 30, 2023 16:49
@dennwc dennwc self-assigned this Nov 30, 2023
@dennwc dennwc marked this pull request as draft November 30, 2023 16:56
@dennwc
Copy link
Contributor Author

dennwc commented Nov 30, 2023

Wait, actually I need one more function here...

@dennwc dennwc marked this pull request as ready for review November 30, 2023 17:03
@dennwc
Copy link
Contributor Author

dennwc commented Nov 30, 2023

Should be good now.

@dennwc dennwc changed the title Move SIP rules from LiveKit server Move SIP rules evaluation from LiveKit server Nov 30, 2023
@Sean-Der Sean-Der merged commit ec88d89 into main Nov 30, 2023
3 checks passed
@Sean-Der Sean-Der deleted the sip_rules branch November 30, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees

@dennwc dennwc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennwc @Sean-Der