Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of some egress images fields naming #485

Merged
merged 15 commits into from
Sep 29, 2023
Merged

Improve consistency of some egress images fields naming #485

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a98b5ca
Add egress image output
biglittlebigben Aug 29, 2023
e29f543
generated protobuf
github-actions[bot] Aug 29, 2023
23a921b
indentation
biglittlebigben Aug 29, 2023
daa2bd6
Merge remote-tracking branch 'origin/benjamin/egress_image_output' in…
biglittlebigben Aug 29, 2023
5315965
fixes
biglittlebigben Sep 1, 2023
9689ed3
generated protobuf
github-actions[bot] Sep 1, 2023
b273085
cleanup
biglittlebigben Sep 1, 2023
185ba34
Merge remote-tracking branch 'origin/main' into benjamin/egress_image…
biglittlebigben Sep 18, 2023
4581320
Merge remote-tracking branch 'origin/benjamin/egress_image_output' in…
biglittlebigben Sep 18, 2023
d7401d2
Image results
biglittlebigben Sep 27, 2023
4bcfcf7
Merge remote-tracking branch 'origin/main' into benjamin/egress_image…
biglittlebigben Sep 27, 2023
ff399a8
Merge remote-tracking branch 'origin/main' into benjamin/egress_image…
biglittlebigben Sep 28, 2023
0213a08
Merge remote-tracking branch 'origin/main' into benjamin/egress_image…
biglittlebigben Sep 29, 2023
b6702bd
naming consistency
biglittlebigben Sep 29, 2023
d9c997e
generated protobuf
github-actions[bot] Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
indentation
  • Loading branch information
@biglittlebigben
biglittlebigben committed Aug 29, 2023
commit 23a921bb2d68421edf5901a27c66632b0e5832d4
8 changes: 4 additions & 4 deletions livekit_egress.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ enum ImageFileSuffix {

message ImageOutput {
uint32 capture_interval = 1; // in seconds (required)
int32 width = 2; // (required)
int32 width = 2; // (required)
int32 height = 3; // (required)
string filename_prefix = 4; // (optional)
ImageFileSuffix filename_suffix = 5; // (optional, default INDEX)
Expand Down Expand Up @@ -286,9 +286,9 @@ message UpdateStreamRequest {
}

message UpdateOutputsRequest {
string egress_id = 1;
repeated ImageOutput add_image_outputs = 2;
repeated ImageOutput remove_image_outputs = 3;
string egress_id = 1;
repeated ImageOutput add_image_outputs = 2;
repeated ImageOutput remove_image_outputs = 3;
}

message ListEgressRequest {
Expand Down