Ingress protobufs #113
Ingress protobufs #113
Conversation
| // desired mime_type to publish to room | ||
| string mime_type = 3; | ||
| uint32 bitrate = 4; | ||
| bool dtx = 5; |
There was a problem hiding this comment.
how are we going to use this? Are we planning to implement a VAD module in the RTMP (or any ingress) -> WebRTC bridge?
There was a problem hiding this comment.
we'll transcode the input into a format supported by WebRTC.
| string mime_type = 3; | ||
| // simulcast layers to publish, when empty, it'll pick default simulcast | ||
| // layers at 1/2 and 1/4 of the dimensions | ||
| repeated VideoLayer layers = 4; |
There was a problem hiding this comment.
Guessing the idea is to encode simulcast at the bridge? Also, should we encode simulcast by default? Guess it does make sense especially to have layers if we are doing SVC.
There was a problem hiding this comment.
yeah, I think we should enable simulcast by default since it'll be needed to ensure uninterrupted streams for lower bandwidth users.
The way to override is just to publish a single layer.
| service Ingress { | ||
| rpc CreateIngress(CreateIngressRequest) returns (IngressInfo); | ||
| rpc ListIngress(ListIngressRequest) returns (ListIngressResponse); | ||
| rpc DeleteIngress(DeleteIngressRequest) returns (google.protobuf.Empty); |
There was a problem hiding this comment.
Should this have a response of success/failure at least?
There was a problem hiding this comment.
failures would be signaled with a different status code in Twirp-land. (i.e. 500)
|
|
||
| enum IngressInput { | ||
| RTMP_INPUT = 0; | ||
| // FILE_INPUT = 1; |
There was a problem hiding this comment.
yeah, will uncomment them when we start implementing them.
No description provided.