Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-initiated unpublish & permissions #107

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Server-initiated unpublish & permissions #107

merged 2 commits into from
Mar 21, 2022

Conversation

davidzhao
Copy link
Member

@davidzhao davidzhao commented Mar 20, 2022

Enable server to unpublish tracks. i.e. when a participant's publish permissions are revoked.

Also cleaned up participant permissions, and returning them to clients so each participant is aware of its and others' permissions.

// allow participant to publish data
bool can_publish_data = 3;
// indicates that it's hidden to others
bool hidden = 7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gaps are due to deprecated stuff in between?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, for backwards compatibility, field numbers cannot change.

@davidzhao davidzhao merged commit 56fa20a into main Mar 21, 2022
@davidzhao davidzhao deleted the remote-unpublish branch March 21, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants