Skip to content

Commit

Permalink
improved release controller
Browse files Browse the repository at this point in the history
  • Loading branch information
cebe committed Feb 1, 2017
1 parent 72cd849 commit bd59d8f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions build/controllers/ReleaseController.php
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,15 @@ public function actionRelease(array $what)
$this->stdout("\n");

$this->stdout("Before you make a release briefly go over the changes and check if you spot obvious mistakes:\n\n", Console::BOLD);
$gitDir = reset($what) === 'framework' ? 'framework/' : '';
$gitVersion = $versions[reset($what)];
if (strncmp('app-', reset($what), 4) !== 0) {
$this->stdout("- no accidentally added CHANGELOG lines for other versions than this one?\n");
$this->stdout("- no accidentally added CHANGELOG lines for other versions than this one?\n\n git diff $gitVersion.. ${gitDir}CHANGELOG.md\n\n");
$this->stdout("- are all new `@since` tags for this relase version?\n");
}
$this->stdout("- other issues with code changes?\n\n git diff -w $gitVersion.. ${gitDir}\n\n");
$travisUrl = reset($what) === 'framework' ? '' : '-'.reset($what);
$this->stdout("- are unit tests passing on travis? https://travis-ci.org/yiisoft/yii2$travisUrl/builds\n");
$this->stdout("- other issues with code changes?\n");
$this->stdout("- also make sure the milestone on github is complete and no issues or PRs are left open.\n\n");
$this->printWhatUrls($what, $versions);
$this->stdout("\n");
Expand Down

0 comments on commit bd59d8f

Please sign in to comment.