Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the fix for the boolean uppercase-value attribute validation #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

citysitesdev
Copy link

Оften the logical value of the attribute is written with a capital letter, for example, Truе. However, the validator in "ymlparser" does not pass such values. I suggest the following improvement to be written in /src/Offer/AOffer.php

@vsdm
Copy link

vsdm commented Sep 25, 2018

What to do with "tRue"?
I think it should be like this
if ($this->store !== null && strtolower($this->store) !== 'true' && strtolower($this->store) !== 'false')

@shaperman
Copy link

What to do with "tRue"?

I believe that in this context "tRue" is a mistake and the result of validation should be negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants