Fix cyclic categories

lireincore · Sep 9, 2017 · a839295 · a839295
1 parent 980dc46
commit a839295
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Shop.php b/src/Shop.php
@@ -465,13 +465,20 @@ public function getCategoryParent($id)
     public function getCategoryHierarchy($id)
     {
         $parents = [];
+        $ids = [];
 
         if (array_key_exists($id, $this->categories)) {
-            $parents[$id] = $this->categories[$id];
+            $parents[] = $this->categories[$id];
             $pid = $id;
+            $ids[] = $pid;
 
-            while (($parent = $this->getCategoryParent($pid)) !== null) {
+            while (null !== $parent = $this->getCategoryParent($pid)) {
                 $pid = $parent->getId();
+
+                if (in_array($pid, $ids, true)) {
+                    break;
+                }
+                $ids[] = $pid;
                 array_unshift($parents, $parent);
             }
         }