Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lireincore committed Oct 3, 2016
1 parent d95c617 commit 9ceff30
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 14 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ try {
$yml->parse($filepath);
$date = $yml->getDate();
$shop = $yml->getShop();
if ($shop->isValid) {
if ($shop->isValid()) {
$offersCount = $shop->getOffersCount();
$shopData = $shop->getData();
//...
foreach ($yml->getOffers() as $offer) {
if ($offer->isValid) {
$offerCategoryHierarchy = $shop->getCategoryHierarchy($offer->getCategoryId);
if ($offer->isValid()) {
$offerCategoryHierarchy = $shop->getCategoryHierarchy($offer->getCategoryId());
$offerData = $offer->getData();
//...
} else {
Expand Down
31 changes: 20 additions & 11 deletions src/YML.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

namespace LireinCore\YMLParser;

use \LireinCore\YMLParser\Offer\VendorModelOffer;
use \LireinCore\YMLParser\Offer\BookOffer;
use \LireinCore\YMLParser\Offer\AudioBookOffer;
use \LireinCore\YMLParser\Offer\ArtistTitleOffer;
use \LireinCore\YMLParser\Offer\MedicineOffer;
use \LireinCore\YMLParser\Offer\EventTicketOffer;
use \LireinCore\YMLParser\Offer\TourOffer;
use \LireinCore\YMLParser\Offer\SimpleOffer;

class YML
{
/**
Expand Down Expand Up @@ -85,7 +94,7 @@ public function getShop()
}

/**
* @return \Generator|\LireinCore\YMLParser\Offer\SimpleOffer[]|\LireinCore\YMLParser\Offer\VendorModelOffer[]|\LireinCore\YMLParser\Offer\BookOffer[]||\LireinCore\YMLParser\Offer\AudioBookOffer[]||\LireinCore\YMLParser\Offer\ArtistTitleOffer[]||\LireinCore\YMLParser\Offer\MedicineOffer[]||\LireinCore\YMLParser\Offer\EventTicketOffer[]||\LireinCore\YMLParser\Offer\TourOffer[]
* @return \Generator|SimpleOffer[]|VendorModelOffer[]|BookOffer[]|AudioBookOffer[]|ArtistTitleOffer[]|MedicineOffer[]|EventTicketOffer[]|TourOffer[]
* @throws \Exception
*/
public function getOffers()
Expand Down Expand Up @@ -136,7 +145,7 @@ protected function parseShop()
}

/**
* @return \LireinCore\YMLParser\Offer\AOffer
* @return SimpleOffer|VendorModelOffer|BookOffer|AudioBookOffer|ArtistTitleOffer|MedicineOffer|EventTicketOffer|TourOffer
*/
protected function parseOffer()
{
Expand Down Expand Up @@ -270,27 +279,27 @@ protected function read()

/**
* @param $type
* @return \LireinCore\YMLParser\Offer\AOffer
* @return SimpleOffer|VendorModelOffer|BookOffer|AudioBookOffer|ArtistTitleOffer|MedicineOffer|EventTicketOffer|TourOffer
*/
protected function createOffer($type)
{
switch ($type) {
case 'vendor.model':
return new \LireinCore\YMLParser\Offer\VendorModelOffer();
return new VendorModelOffer();
case 'book':
return new \LireinCore\YMLParser\Offer\BookOffer();
return new BookOffer();
case 'audiobook':
return new \LireinCore\YMLParser\Offer\AudioBookOffer();
return new AudioBookOffer();
case 'artist.title':
return new \LireinCore\YMLParser\Offer\ArtistTitleOffer();
return new ArtistTitleOffer();
case 'medicine':
return new \LireinCore\YMLParser\Offer\MedicineOffer();
return new MedicineOffer();
case 'event-ticket':
return new \LireinCore\YMLParser\Offer\EventTicketOffer();
return new EventTicketOffer();
case 'tour':
return new \LireinCore\YMLParser\Offer\TourOffer();
return new TourOffer();
default:
return new \LireinCore\YMLParser\Offer\SimpleOffer();
return new SimpleOffer();
}
}
}

0 comments on commit 9ceff30

Please sign in to comment.