Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline to linkerd install error output #11917

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Commits on Jan 11, 2024

  1. Add newline to linkerd install error output

    The `errMsgCannotInitializeClient` format string did not include a
    trailing newline, unlike other error messages. This caused the user's
    prompt to appear immediately after the error without a newline.
    
    Add a trailing newline to `errMsgCannotInitializeClient`.
    
    Before:
    ```
    $ linkerd install --context not-a-cluster
    Unable to install the Linkerd control plane. Cannot connect to the Kubernetes cluster:
    
    error configuring Kubernetes API client: context "not-a-cluster" does not exist
    
    You can use the --ignore-cluster flag if you just want to generate the installation config.$
    ```
    
    After:
    ```
    $ bin/go-run cli install --context not-a-cluster
    Unable to install the Linkerd control plane. Cannot connect to the Kubernetes cluster:
    
    error configuring Kubernetes API client: context "not-a-cluster" does not exist
    
    You can use the --ignore-cluster flag if you just want to generate the installation config.
    $
    ```
    
    Signed-off-by: Andrew Seigner <[email protected]>
    siggy committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e9eeb40 View commit details
    Browse the repository at this point in the history