Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-23.10.4 #11543

Merged
merged 4 commits into from
Oct 27, 2023
Merged

edge-23.10.4 #11543

merged 4 commits into from
Oct 27, 2023

Conversation

mateiidavid
Copy link
Member

This edge release includes a fix for the ServiceProfile CRD resource schema. The schema incorrectly required not response matches to be arrays, while the in-cluster validator parsed not response matches as objects. In addition, an issues has been fixed in linkerd profile. When used with the --open-api flag, it would not strip trailing slashes when generating a resource from swagger specifications.

  • Fixed an issue where trailing slashes wouldn't be stripped when generating ServiceProfile resources through linkerd profile --open-api (#11519)
  • Fixed an issue in the ServiceProfile CRD schema. The schema incorrectly required that a not response match should be an array, which the service profile validator rejected since it expected an object. The schema has been updated to properly indicate that not values should be an object (#11510; fixes #11483)
  • Improved logging in the destination controller by adding the client pod's name to the logging context. This will improve visibility into the messages sent and received by the control plane from a specific proxy (#11532)
  • Fixed an issue in the destination controller where the metadata API would not initialize a Job informer. The destination controller uses the metadata API to retrieve Job metadata, and relies mostly on informers. Without an initialized informer, an error message would be logged, and the controller relied on direct API calls (#11541; fixes #11531)

This edge release includes a fix for the `ServiceProfile` CRD resource schema.
The schema incorrectly required `not` response matches to be arrays, while the
in-cluster validator parsed `not` response matches as objects. In addition, an
issues has been fixed in `linkerd profile`. When used with the `--open-api`
flag, it would not strip trailing slashes when generating a resource from
swagger specifications.

* Fixed an issue where trailing slashes wouldn't be stripped when generating
  `ServiceProfile` resources through `linkerd profile --open-api` ([#11519])
* Fixed an issue in the `ServiceProfile` CRD schema. The schema incorrectly
  required that a `not` response match should be an array, which the service
  profile validator rejected since it expected an object. The schema has been
  updated to properly indicate that `not` values should be an object ([#11510];
  fixes [#11483])
* Improved logging in the destination controller by adding the client pod's
  name to the logging context. This will improve visibility into the messages
  sent and received by the control plane from a specific proxy ([#11532])
* Fixed an issue in the destination controller where the metadata API would not
  initialize a `Job` informer. The destination controller uses the metadata API
  to retrieve `Job` metadata, and relies mostly on informers. Without an
  initialized informer, an error message would be logged, and the controller
  relied on direct API calls ([#11541]; fixes [#11531])

[#11541]: #11532
[#11532]: #11532
[#11531]: #11531
[#11519]: #11519
[#11510]: #11510
[#11483]: #11483

Signed-off-by: Matei David <[email protected]>
@mateiidavid mateiidavid requested a review from a team as a code owner October 27, 2023 15:27
@mateiidavid
Copy link
Member Author

mateiidavid commented Oct 27, 2023

Note:

you'll see some changes made to the previous edge's notes. The issue reference # (for the destination queue update) was wrong and it pointed to the SP fix. Changed it to the actual # it was supposed to reference so I can pass the markdown lint step.

@@ -14,7 +14,7 @@ dependencies:
- name: partials
version: 0.1.0
repository: file://../partials
version: 1.8.0
version: 1.8.1-edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be 1.9.0-edge instead, so that if there's change in CRDs somewhere in 2.14.x, it can be bumped in that branch without appearing after this edge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see.

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo linkerd-crds chart version

Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
@mateiidavid mateiidavid merged commit 798c5d9 into main Oct 27, 2023
35 checks passed
@mateiidavid mateiidavid deleted the matei/edge-23.10.4 branch October 27, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants