Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update release workflow to use arbitrary references #2818

Merged
merged 5 commits into from
Mar 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
publish settings
  • Loading branch information
olix0r committed Mar 20, 2024
commit 22da09fdb46a7adc76ebef0bc029cf9871a17611
8 changes: 5 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ jobs:
version: ${{ steps.meta.outputs.version }}
package: ${{ github.event_name == 'workflow_dispatch' || steps.changed.outputs.any_changed == 'true' }}
profile: ${{ inputs.profile || 'release' }}
publish: ${{ inputs.publish == 'true' }}
ref: ${{ inputs.ref || github.ref }}
tag: "${{ inputs.tag-prefix || 'release/' }}v${{ steps.meta.outputs.version }}"
prerelease: ${{ inputs.prerelease }}
Expand All @@ -114,6 +115,7 @@ jobs:
echo 'needs.meta.outputs.version: ${{ needs.meta.outputs.version }}'
echo 'needs.meta.outputs.package: ${{ needs.meta.outputs.package }}'
echo 'needs.meta.outputs.profile: ${{ needs.meta.outputs.profile }}'
echo 'needs.meta.outputs.publish: ${{ needs.meta.outputs.publish }}'
echo 'needs.meta.outputs.ref: ${{ needs.meta.outputs.ref }}'
echo 'needs.meta.outputs.prerelease: ${{ needs.meta.outputs.prerelease }}'
echo 'needs.meta.outputs.draft: ${{ needs.meta.outputs.draft }}'
Expand All @@ -129,7 +131,7 @@ jobs:

# If we're not actually building on a release tag, don't short-circuit on
# errors. This helps us know whether a failure is platform-specific.
continue-on-error: ${{ inputs.publish != 'true' }}
continue-on-error: ${{ needs.meta.outputs.publish != 'true' }}
runs-on: ubuntu-latest
timeout-minutes: 40
container: docker://ghcr.io/linkerd/dev:v43-rust-musl
Expand Down Expand Up @@ -177,9 +179,9 @@ jobs:
path: artifacts
- run: du -h artifacts/**/*
# Publish the release.
- if: inputs.publish == 'true'
- if: needs.meta.outputs.publish == 'true'
run: git push origin '${{ needs.meta.outputs.tag }}'
- if: inputs.publish == 'true'
- if: needs.meta.outputs.publish == 'true'
uses: softprops/action-gh-release@9d7c94cfd0a1f3ed45544c887983e9fa900f0564
with:
name: v${{ needs.meta.outputs.version }}
Expand Down