Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests and workflow #4

Merged
merged 1 commit into from
May 9, 2023
Merged

Integration tests and workflow #4

merged 1 commit into from
May 9, 2023

Conversation

ryannedolan
Copy link
Collaborator

@ryannedolan ryannedolan commented May 8, 2023

Tweaks to enable running integration tests in the form of a SQL script. A similar SQL script is used for a new readiness probe, which enables the workflow to wait until the cluster is ready.

Testing

$ make integration-tests
...
PASS

Also, the GitHub workflow below is passing.

@ryannedolan ryannedolan force-pushed the integration-tests branch 6 times, most recently from 30cb372 to d334716 Compare May 8, 2023 22:24
Copy link
Collaborator

@ehoner ehoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The consistency between the local environment and integration-testing is spectacular. The only difference I see is with java. Is this something that gradle will enforce/manage?

@ryannedolan ryannedolan merged commit 668ea34 into main May 9, 2023
@ryannedolan ryannedolan deleted the integration-tests branch May 9, 2023 01:47
ryannedolan added a commit that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants